Fix internalAuthors option being silently ignored#23
Merged
Conversation
The generic built-in formatter lookup matched "github" before the options-aware path, so options (internalAuthors, repo, etc.) were silently ignored. Reorder the branches so the github-specific path runs first. Add loadFormatter tests covering this case. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Collaborator
|
The changes in this PR will be included in the next version bump.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
loadFormatterhad a bug where the generic built-in formatter lookup matched"github"before the options-aware code path, so config like["github", { "internalAuthors": [...] }]silently dropped the options and created the formatter with defaultsgithub-specific path (which forwards options tocreateGithubFormatter) runs firstloadFormattertests covering options passthrough, bare"github"string, and default formatterTest plan
bumpy ci releaseno longer include "Thanks @..." for internal authors🐸 Generated with Claude Code